[PATCH] perl@27437 fix File::Path::mkpath so that perl installs on VMS

In reply to a previous message thread John E. Malmberg 
<wb8tyw@qsl.net> wrote on 03/08/2006 07:29:10 PM:

> Clearly something is wrong, the '/000000' should not be present because 
> it will not be understood by the C runtime.  It might help if you can 
> find out what is adding it.
> 
> I am pretty sure that I exorcised all the code that was incorrectly 
> adding '/000000' from both vms.c and configure.com.

I found two files in [.lib.file]*.pm that mentioned 000000.  One 
of them was Basename.pm and I assume it is correctly stripping 
000000 from rooted logical paths for very good reasons and requires
no modification.

To fix the bug with installperl I merely had to follow your useful 
hint and strip the 000000 from File::Path::mkpath().  With the 
following applied to perl@27437 I was able to get File/Path tests 
to pass OK as well as to run "mmk install" successfully:

diff -ru bleed_at_27437/lib/File/Path.pm bleed/lib/File/Path.pm
--- bleed_at_27437/lib/File/Path.pm     2006-03-09 09:19:50.743284000 
-0500
+++ bleed/lib/File/Path.pm      2006-03-09 09:23:02.778055000 -0500
@@ -161,9 +161,6 @@
        if ($Is_VMS) {
            next if $path eq '/';
            $path = VMS::Filespec::unixify($path);
-           if ($path =~ m:^(/[^/]+)/?\z:) {
-               $path = $1.'/000000';
-           }
        }
        next if -d $path;
        my $parent = File::Basename::dirname($path);
End of Patch.

Ironically we could on VMS easily write a test that exercises
File::Path::mkpath('/rooted_logical'); but that would be
a test that would have to be skipped on Unix unless you
were running as root and running as root is not advised
(nor should it be required for building or testing perl).

With that applied I see the following test failures
using HP C V7.1-011 on OpenVMS IA64 V8.2-1, with Multinet 5.1,
mmk V3.9-10:

lib/Module/Build/t/basic...................................FAILED--expected 
55 tests, saw 13
lib/Module/Build/t/destinations............................FAILED--expected 
92 tests, saw 34
lib/Module/Build/t/ext.....................................FAILED at test 
92
lib/Module/Build/t/extend..................................FAILED at test 
6
lib/Module/Build/t/files...................................FAILED--expected 
6 tests, saw 2
lib/Module/Build/t/install.................................FAILED at test 
5
lib/Module/Build/t/manifypods..............................FAILED--expected 
21 tests, saw 2
lib/Module/Build/t/metadata................................FAILED--expected 
46 tests, saw 8
lib/Module/Build/t/metadata2...............................FAILED--expected 
18 tests, saw 4
lib/Module/Build/t/ppm.....................................FAILED--expected 
12 tests, saw 1
lib/Module/Build/t/runthrough..............................FAILED at test 
13
lib/Module/Build/t/tilde...................................FAILED--expected 
11 tests, saw 0
lib/Module/Build/t/xs......................................FAILED at test 
2
lib/Net/Ping/t/510_ping_udp................................FAILED at test 
2
lib/Pod/Simple/t/corpustest................................FAILED--expected 
43 tests, saw 2

lib/Tie/File/t/28_mtwrite..................................FAILED--expected 
2252 tests, saw 2026 

In message 
http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2006-03/msg00266.html
I submitted what I considered a fix for the corpustest failure that
had an odd subject header and was not tested on other platforms.
Would the pumpking(s) like it if I resubmitted that with a separate
subject line and testing on Unix?

Does anyone running TCPIP Services also see a failure 
of lib/Net/Ping/t/510_ping_udp.t?  Thanks.

Peter Prymmer

This MUA is Notes - hence lines get wrapped oddly.  Hence I will also
include this patch as a MIME attachment:

 
 

• [PATCH] perl@27437 fix File::Path::mkpath so that perl installs on VMS by Peter Prymmer
• Re: [PATCH] perl@27437 fix File::Path::mkpath so that perl installs on VMS by Craig A. Berry